Skip to content

chore: adopt widened comment-hygiene policy and re-pin ci-workflows @9567b8b#9

Merged
kyle-sexton merged 1 commit into
mainfrom
chore/comment-hygiene-resync-repin
Jun 25, 2026
Merged

chore: adopt widened comment-hygiene policy and re-pin ci-workflows @9567b8b#9
kyle-sexton merged 1 commit into
mainfrom
chore/comment-hygiene-resync-repin

Conversation

@kyle-sexton

Copy link
Copy Markdown
Contributor

What

  • Re-sync modules/comment-hygiene/comment-hygiene-patterns.sh to the standards SSOT (blob 7ebe897). The widened policy now also flags cc-issue, GitHub closing-keyword+#N, issue/issues/tracked refs, owner/repo#N and GH-N, and scans block (/* *) and HTML (<!--) comment lines.
  • Re-pin every melodic-software/ci-workflows action and reusable-workflow ref (ci.yml, link-check.yml) to current main (9567b8b, 2026-06-24).

Why

No Dependabot exists for vendored configs, so the patterns re-sync is manual. Re-pinning to current ci-workflows main activates the matching coarse prefilter, git-tracked file walks, and inline PR annotations alongside the widened policy. Dependabot would later bump the SHA pins on its own cycle; this brings them current now.

Verification

  • Vendored blob byte-identical to SSOT (git rev-parse :… == 7ebe897, i/lf).
  • All ci-workflows refs at 9567b8b.
  • Comment-hygiene scan clean under the widened policy.

…9567b8b

Re-sync modules/comment-hygiene/comment-hygiene-patterns.sh to the standards
SSOT: the policy now also flags cc-issue, GitHub closing-keyword+#N,
issue/issues/tracked refs, owner/repo#N and GH-N, and scans block (/* *) and
HTML (<!--) comment lines.

Re-pin every melodic-software/ci-workflows action and reusable-workflow ref to
current main so the matching coarse prefilter, git-tracked file walks and inline
PR annotations activate alongside the widened policy.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@kyle-sexton
kyle-sexton merged commit eec5702 into main Jun 25, 2026
14 checks passed
@kyle-sexton
kyle-sexton deleted the chore/comment-hygiene-resync-repin branch June 25, 2026 02:09

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 60506106e4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

# LETTERS-NUMBER shape collides with technical tokens (UTF-8, SHA-256,
# ISO-8601, RFC-2119, CVE-2025-…, P-256) and POSIX ERE cannot exclude them.
# Deferred until a Jira-using consumer supplies an explicit project-key list.
done < <(awk '/^[[:space:]]*(\/\/|#|\/\*|\*|<!--)/ { print NR ":" $0 }' <<<"$content")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Don’t treat every leading star as a comment

When this policy is used by the bumped comment-hygiene action, the prefilter also admits leading * lines for the default .js/.ts/.py file set, so this validator now treats real code that starts with an operator/star as a comment. A valid generator method or unpacking line such as *todo() {} or *todo, rest = seq is not a comment, but nocasematch makes the existing TODO marker rule report it and fail CI. Please narrow the block-comment continuation case, for example to * followed by whitespace, so non-comment code that begins with *todo is not blocked.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant