[segmentationRDS] Fix: Do not insert empty bounding boxes in merged tracking extraction - #69
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes extract_tracking in segmentationRDS/bboxUtils.py to avoid inserting missing per-frame boxes into raw_boxes, preventing downstream failures when computing target sizes / expanding boxes.
Changes:
- In both the
mergedandforwardbranches, only writes toraw_boxeswhen a box is present for the given(frame_idx, obj_id).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
cbentejac
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a small but important fix to the
extract_trackingfunction insegmentationRDS/bboxUtils.py. The change ensures that only non-empty bounding boxes are added to theraw_boxesdictionary, which helps prevent potential issues with empty or missing data.raw_boxesif they are present, avoiding the insertion ofNonevalues.