split lvmd config from topolvm#227
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe Changeslvmd ConfigMap Extraction
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
still debugging, the failure timing matches topolvm didn't come up. will update. |
|
maybe some outage? rebased now. |
we can bind mount the lvmd config during runtime for any configuration changes like sparegb or use thinpool config, the default behaviour is unchaged. Signed-off-by: Leela Venkaiah G <leelavg@thoughtexpo.com>
we can bind mount the lvmd config during runtime for any configuration changes like sparegb or use thinpool config, the default behaviour is unchaged.
Summary by CodeRabbit