Skip to content

split lvmd config from topolvm#227

Open
leelavg wants to merge 1 commit into
microshift-io:mainfrom
leelavg:lvmd-config
Open

split lvmd config from topolvm#227
leelavg wants to merge 1 commit into
microshift-io:mainfrom
leelavg:lvmd-config

Conversation

@leelavg

@leelavg leelavg commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

we can bind mount the lvmd config during runtime for any configuration changes like sparegb or use thinpool config, the default behaviour is unchaged.

Summary by CodeRabbit

  • New Features
    • TopoLVM’s configuration is now organized into separate generated manifests for easier management, including a dedicated LVMD configuration.
  • Refactor
    • The generated asset set was reorganized by removing the LVMD ConfigMap from the main TopoLVM manifest and adding it as a standalone manifest.
    • The kustomization output was updated to include the new LVMD manifest resource.

@leelavg leelavg requested a review from a team as a code owner July 6, 2026 06:13
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3be0e9f9-fd6a-4e72-b940-cb2757fbc08a

📥 Commits

Reviewing files that changed from the base of the PR and between 61c288a and 3e754bf.

📒 Files selected for processing (4)
  • src/topolvm/assets/02-topolvm.yaml
  • src/topolvm/assets/03-lvmd.yaml
  • src/topolvm/assets/kustomization.yaml
  • src/topolvm/generate_manifests.sh
💤 Files with no reviewable changes (1)
  • src/topolvm/assets/02-topolvm.yaml
✅ Files skipped from review due to trivial changes (1)
  • src/topolvm/assets/kustomization.yaml
🚧 Files skipped from review as they are similar to previous changes (2)
  • src/topolvm/generate_manifests.sh
  • src/topolvm/assets/03-lvmd.yaml

📝 Walkthrough

Walkthrough

The topolvm-lvmd-0 ConfigMap is moved from 02-topolvm.yaml into a new 03-lvmd.yaml manifest. The kustomization resource list and manifest generation script are updated to include the new file.

Changes

lvmd ConfigMap Extraction

Layer / File(s) Summary
New lvmd manifest and removal from main manifest
src/topolvm/assets/03-lvmd.yaml, src/topolvm/assets/02-topolvm.yaml
The topolvm-lvmd-0 ConfigMap is removed from 02-topolvm.yaml and added as a standalone 03-lvmd.yaml file with the lvmd.yaml payload.
Kustomization and generation script wiring
src/topolvm/assets/kustomization.yaml, src/topolvm/generate_manifests.sh
kustomization.yaml now includes 03-lvmd.yaml, and generate_manifests.sh writes the ConfigMap to that file, removes it from 02-topolvm.yaml, and updates generated kustomization resources.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: ggiguash

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: moving lvmd configuration out of the main TopoLVM manifest.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@leelavg

leelavg commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

still debugging, the failure timing matches topolvm didn't come up. will update.

@leelavg

leelavg commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

maybe some outage?

time="2026-07-06T10:06:12Z" level=fatal msg="copying image 2/2 from manifest list:
 reading blob sha256:f0e298721aa8206a84c7cf45c6b2e12dcb7c6c3f0bbf4daeb6b2c640aba70ffd: 
Get \"https://cdn01.quay.io/...": EOF"

rebased now.

we can bind mount the lvmd config during runtime for any configuration
changes like sparegb or use thinpool config, the default behaviour is
unchaged.

Signed-off-by: Leela Venkaiah G <leelavg@thoughtexpo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant