Fix Unreal crash by changing rpclib to a fork version - #2340
Merged
Ratnesh Madaan (madratman) merged 4 commits intoJul 24, 2020
Conversation
The original rpclib have bugs that cause Unreal crashes, sometimes the client also crashes as well. It lacks maintenance for two years, but a fork qchateau/rpclib offers patches.
Contributor
|
Will need changes to Unity/build.sh and rpc-setup.cmake as well for Unity |
Contributor
Author
Thanks for your addition! I've merged it into this PR. |
Xiaocheng Song (songxiaocheng)
requested review from
Ratnesh Madaan (madratman) and
Shital Shah (sytelus)
and removed request for
Ratnesh Madaan (madratman)
January 19, 2020 13:44
Ratnesh Madaan (madratman)
force-pushed
the
bug_fixes/rpclib
branch
from
July 24, 2020 08:41
5183006 to
a621e79
Compare
Ratnesh Madaan (madratman)
force-pushed
the
bug_fixes/rpclib
branch
from
July 24, 2020 08:42
a621e79 to
bff7017
Compare
Contributor
|
Thanks Xiaocheng Song (@songxiaocheng) for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original rpclib have bugs that cause Unreal crashes, sometimes the client also crashes as well. It lacks maintenance for two years, but a fork qchateau/rpclib offers patches, which fixes crashes in my case.
Related issues: #1675, #631, #567
Related issues in original rpclib repo: rpclib/rpclib#161, rpclib/rpclib#175
Due to the lack of maintenance, maybe we can consider transfer code to other open-source RPC libraries in the future.