Skip to content

[docs] Update CHANGELOG.md - #2555

Merged
Ratnesh Madaan (madratman) merged 2 commits into
microsoft:masterfrom
rajat2004:changelog
Apr 30, 2020
Merged

[docs] Update CHANGELOG.md#2555
Ratnesh Madaan (madratman) merged 2 commits into
microsoft:masterfrom
rajat2004:changelog

Conversation

@rajat2004

@rajat2004 Rajat Singhal (rajat2004) commented Apr 9, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

As mentioned in the Changelog, only keeping the bigger updates, not including bug-fixes, etc.

@rajat2004

Rajat Singhal (rajat2004) commented Apr 9, 2020

Copy link
Copy Markdown
Contributor Author

There's a What's New section in the main Readme, details from that will need to be included. Should that be kept or just point to Changelog?

@rajat2004 Rajat Singhal (rajat2004) mentioned this pull request Apr 9, 2020
Closed
@rajat2004
Rajat Singhal (rajat2004) force-pushed the changelog branch 4 times, most recently from 2ecbab1 to 488d833 Compare April 12, 2020 15:24
@madratman

Ratnesh Madaan (madratman) commented Apr 13, 2020

Copy link
Copy Markdown
Contributor

Please remove whitespace changes in the diff - https://stackoverflow.com/questions/3515597/add-only-non-whitespace-changes.
What's new should have the key highlights

@rajat2004

Rajat Singhal (rajat2004) commented Apr 13, 2020

Copy link
Copy Markdown
Contributor Author

So the current changes to What's new are okay? And then some more detailed info to Changelog such as imp bug fixes?

@rajat2004

Rajat Singhal (rajat2004) commented Apr 14, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Removed the whitespace changes (need to fix that in some other PRs as well)
Will add some other bug-fixes, etc in Changelog

The items in Changelog and What's New should be those which are of significance to the end-user?

@rajat2004
Rajat Singhal (rajat2004) force-pushed the changelog branch 4 times, most recently from f8565c7 to 085896c Compare April 16, 2020 02:45
@rajat2004

Rajat Singhal (rajat2004) commented Apr 22, 2020

Copy link
Copy Markdown
Contributor Author

Looks okay to me, Changelog now has info about changes in April as well

@madratman

Ratnesh Madaan (madratman) commented Apr 29, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

" * Support for PX4 master " -> this is incorrect.
we support v1.10 now. Chris is working on the master support in the latest PR.

lgtm apart from that

@rajat2004

Rajat Singhal (rajat2004) commented Apr 30, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Ratnesh Madaan (@madratman) Fixed, when I wrote this, I thought it was working with the master branch as well
Changelog now includes changes till today as well

In the Readme What's new section, I've only kept things which are in the latest release

@madratman
Ratnesh Madaan (madratman) merged commit a0b5418 into microsoft:master Apr 30, 2020
@rajat2004
Rajat Singhal (rajat2004) deleted the changelog branch April 30, 2020 01:29
Ratnesh Madaan (madratman) pushed a commit to ironclownfish/AirSim that referenced this pull request May 2, 2020
@rajat2004 @madratman
[docs] Update CHANGELOG.md (microsoft#2555)
49c5322 
* [docs] Update Readme What's New section

* [docs] Update Changelog.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rajat2004 @madratman