Skip to content

Fix some PX4 issues with latest master branch - #2634

Merged
Ratnesh Madaan (madratman) merged 3 commits into
masterfrom
clovett/vs2019
Apr 30, 2020
Merged

Fix some PX4 issues with latest master branch#2634
Ratnesh Madaan (madratman) merged 3 commits into
masterfrom
clovett/vs2019

Conversation

@lovettchris

@lovettchris Chris Lovett (lovettchris) commented Apr 29, 2020

Copy link
Copy Markdown
Contributor

Fix memory corruption in setThreadName helper function.
Print message when home GPS location is set.
Delay connecting UDP connection to avoid socket errors.

Chris Lovett added 2 commits April 27, 2020 20:36
Chris Lovett Chris Lovett
help folks migrate to 4.24.
64bb8bc
Chris Lovett Chris Lovett
PX4 bug fixes.
c8fb074 
Fix macos build relating to setThreadName helper function.
Print message when home GPS location is set.
Delay connecting UDP connection to avoid socket errors.
@lovettchris Chris Lovett (lovettchris) mentioned this pull request Apr 29, 2020
Closed
@rajat2004

Rajat Singhal (rajat2004) commented Apr 29, 2020

Copy link
Copy Markdown
Contributor

One thing which I had noticed sometime back is that PX4 is using the system clock for sending the simulation time. This is in contrast to in Ardupilot where the stepped time is being used

I really have no idea whether this causes any effect or anything, just though I should post my doubt

@lovettchris

Chris Lovett (lovettchris) commented Apr 29, 2020

Copy link
Copy Markdown
Contributor Author

Interesting question about the clock, I'll ping my PX4 friends and see if the actual time delta between ticks makes any difference when PX4 is running in lockstep mode. I doubt it will, but I'll check, thanks.

@lovettchris Chris Lovett (lovettchris) mentioned this pull request Apr 29, 2020
Closed
@madratman

Ratnesh Madaan (madratman) commented Apr 30, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

This seems to be working well with master, v1.11.0-beta1, v1.10.1. Thanks Chris! TomSeestern (@TomSeestern), 斯东Stone (@bys1123), it would be great if you guys can give it a shot as well. (I haven't tried sending cmds with QGC). Just observing the terminal output

@madratman
Ratnesh Madaan (madratman) merged commit 39b8e56 into master Apr 30, 2020
@lovettchris
Chris Lovett (lovettchris) deleted the clovett/vs2019 branch April 30, 2020 01:11
@bys1123

斯东Stone (bys1123) commented Apr 30, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thanks your great works!
cc' Jaeyoung Lim (@Jaeyoung-Lim) Matthias Grob (@MaEtUgR)
Related issues: PX4/PX4-Autopilot#14615 #2477

@lovettchris Chris Lovett (lovettchris) mentioned this pull request May 1, 2020
Closed
@bys1123 斯东Stone (bys1123) mentioned this pull request May 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@madratman Ratnesh Madaan (madratman) Awaiting requested review from madratman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lovettchris @rajat2004 @madratman @bys1123