[Unity] Fix Car API - #2937
Merged
David Zimmermann (zimmy87) merged 3 commits intoMay 24, 2021
Merged
Conversation
Rajat Singhal (rajat2004)
force-pushed
the
fix-unity-car-api
branch
from
August 16, 2020 17:46
f7ab89c to
6a5366c
Compare
Contributor
Author
|
Ratnesh Madaan (@madratman) Sai Vemprala (@saihv) Jonathan (@jonyMarino) If possible, could you have a look at why Travis is not triggering and the Azure Pipelines status aren't getting updated? Seems to be happening for all PRs in the last 2-3 days Edit: Travis does get triggered, but not appearing in the CI checks - https://travis-ci.org/github/microsoft/AirSim/pull_requests |
Rajat Singhal (rajat2004)
force-pushed
the
fix-unity-car-api
branch
from
September 27, 2020 02:42
6a5366c to
cf2e994
Compare
Rajat Singhal (rajat2004)
force-pushed
the
fix-unity-car-api
branch
from
March 7, 2021 11:40
cf2e994 to
456e71c
Compare
Contributor
|
Thank you, this PR solved my problem! Why is it not merged into master yet? |
David Zimmermann (zimmy87)
suggested changes
May 19, 2021
David Zimmermann (zimmy87)
left a comment
Contributor
There was a problem hiding this comment.
Just some minor style changes. Tested with PythonClient\car\hello_car.py, PythonClient\car\drive_straight.py, and PythonClient\car\car_monitor.py, and the PR appears to work as intested
Set API enabled so that it uses API controls rather than keyboard
Rajat Singhal (rajat2004)
force-pushed
the
fix-unity-car-api
branch
from
May 23, 2021 15:18
456e71c to
99089bf
Compare
David Zimmermann (zimmy87)
approved these changes
May 24, 2021
Contributor
|
Thanks for the contribution Rajat Singhal (@rajat2004)! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set API enabled so that it uses API controls rather than keyboard
Plus fix some warnings
Will be easier to review commit wise
Closes #2679, closes #2636, closes #2631
Some more cleanup needs to be done,
keyboard_controls_is actually incorrect and doesn't contain the keypresses, that is actually been done here. It can be seen that the external controls are applied only whenisApiEnabledistrue, which is being added in this PR.CarPawnis supposed to provide thekeyboard_controlsbut is just a placeholder, and doesn't do anything, so I think that can be removedTODO:
CarPawnSimApican fetch the keyboard controls fromCar.cs, without this, thegetCarControlsAPI won't work to fetch the keyboard values.airsim_unity_car_api.mp4
These changes will diverge Unity implementation from Unreal one, but shouldn't be much of a problem