Add Docker for testing ROS wrapper - #3635
Merged
David Zimmermann (zimmy87) merged 3 commits intoSep 16, 2021
Merged
Conversation
Rajat Singhal (rajat2004)
force-pushed
the
ros-docker
branch
from
April 28, 2021 11:30
31ab1dd to
5852b2c
Compare
Rajat Singhal (rajat2004)
force-pushed
the
ros-docker
branch
2 times, most recently
from
May 8, 2021 07:03
683d3f4 to
61333f7
Compare
Rajat Singhal (rajat2004)
force-pushed
the
ros-docker
branch
from
May 23, 2021 15:27
2ba81ac to
a27ed68
Compare
Rajat Singhal (rajat2004)
force-pushed
the
ros-docker
branch
from
July 27, 2021 18:50
a27ed68 to
0f28322
Compare
Rajat Singhal (rajat2004)
force-pushed
the
ros-docker
branch
from
August 12, 2021 03:05
0f28322 to
f902bdc
Compare
Merged
Rajat Singhal (rajat2004)
marked this pull request as draft
August 29, 2021 06:58
Rajat Singhal (rajat2004)
force-pushed
the
ros-docker
branch
from
September 11, 2021 04:15
f902bdc to
052d343
Compare
Rajat Singhal (rajat2004)
marked this pull request as ready for review
September 11, 2021 04:16
Contributor
|
ran the dockerfile and built the ROS wrapper successfully inside and outside of docker, so this looks good to me; thanks for the contribution Rajat Singhal (@rajat2004)! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #
About
This PR adds an example Dockerfile for testing the ROS wrapper. My current ROS install on host is broken (long story), that's why wrote this script.
docker build -t airsim-ros -f Dockerfile-ROS .docker run --rm -it --net=host -v ~/AirSim:/home/testuser/AirSim airsim-ros:latest bashInside container:
source /opt/ros/melodic/setup.bash, or add to .bashrc (echo "source /opt/ros/melodic/setup.bash" >> .bashrc)cd AirSim/ros,catkin build -DCMAKE_C_COMPILER=gcc-8 -DCMAKE_CXX_COMPILER=g++-8(Basically https://microsoft.github.io/AirSim/airsim_ros_pkgs/#build)source devel/setup.bashroslaunch airsim_ros_pkgs airsim_node.launch output:=screenOutput:
Also demonstrates that settings.json isn't required after #3536
TODO:
How Has This Been Tested?
Used the docker container to test that no settings.json file is required if using the latest master AirSim. With a 1.4.0 release, the fallback behaviour is seen -
Screenshots (if appropriate):