Skip to content

Add detection support for all image types - #3788

Merged
David Zimmermann (zimmy87) merged 3 commits into
microsoft:masterfrom
alonfaraj:detection-support-all-image-types
Jun 21, 2021
Merged

Add detection support for all image types#3788
David Zimmermann (zimmy87) merged 3 commits into
microsoft:masterfrom
alonfaraj:detection-support-all-image-types

Conversation

@alonfaraj

Copy link
Copy Markdown
Contributor
  • Extend detection support for all image types
  • UDetectionComponent now generated via c++ to keep it simpler and and without changing BP_PIPCamera asset

Fixes: #

#3472 (comment)

About

Last PR #3472 included image_type in API but supported only Scene.
This PR fix it.

How Has This Been Tested?

Using detection.py script on different image types with Block environment.

- Generate  detection component in c++ and revert BP_PIPcamera
@alonfaraj Alon (alonfaraj) changed the title - Add detection support for all image types Add detection support for all image types Jun 13, 2021
Comment thread Unreal/Plugins/AirSim/Source/PIPCamera.cpp
@rajat2004

Copy link
Copy Markdown
Contributor

Slightly separate from this, there are 3 methods declared in AirBlueprintlib.h without any definition and usage, can be removed

static void addDetectionFilterMeshName(const std::string& name);
static void setDetectionFilterRadius(const float radius_cm);
static void clearDetectionMeshNames();

Comment thread Unreal/Plugins/AirSim/Source/PIPCamera.cpp
@zimmy87

Copy link
Copy Markdown
Contributor

Tested with detection.py script using a variety of different image types. Everything worked as intended so I am moving ahead with merging.

@zimmy87
David Zimmermann (zimmy87) merged commit 40b2978 into microsoft:master Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants