Split commit fetching out of commit checkout - #754
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Separates commit fetching from checkout and invokes it explicitly for code-review workspace setup.
Changes:
- Adds conditional commit fetching.
- Simplifies checkout behavior.
- Updates code-review setup and tests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/bcbench/operations/git_operations.py |
Adds fetch helper and simplifies checkout. |
src/bcbench/operations/__init__.py |
Exports the fetch helper. |
src/bcbench/evaluate/codereview.py |
Fetches missing base commits before setup. |
tests/test_git_operations.py |
Tests checkout and fetch independently. |
tests/test_codereview.py |
Mocks fetching during workspace tests. |
Wenjie Fan (gggdttt)
approved these changes
Jul 28, 2026
Magnus Hartvig Grønbech (Groenbech96)
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split the commit fetching out of commit checkout, so each function is more self-contained.
The fetch is needed because some commits got squashed when the PRs got merged, not a problem in CI because that is handled during repo checkout, mostly a problem in local dev environment.