Uptake capi headers wave 2 - #772
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Moves CAPI header handling into bc-eval 0.3.13 and removes BC-Bench’s local shims.
Changes:
- Upgrades CAPI evaluation workflows to
bc-eval0.3.13. - Removes local taxonomy-header injection and related tests/configuration.
- Simplifies the CAPI bridge to call the client directly.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/bcal-evaluation.yml |
Upgrades bc-eval and removes taxonomy environment variables. |
.github/workflows/summarize-results.yml |
Upgrades the evaluation tool dependency. |
evaluator/_capi_taxonomy.py |
Removes the local evaluator header shim. |
evaluator/scores.py |
Removes shim initialization. |
src/bcbench/agent/bcal/bc_eval_capi_bridge.py |
Removes header injection and retry code. |
tests/test_bcal_capi_bridge.py |
Removes tests for deleted bridge behavior. |
tests/test_capi_taxonomy_evaluator.py |
Removes tests for the deleted evaluator shim. |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
Suppressed comments (1)
src/bcbench/agent/bcal/bc_eval_capi_bridge.py:137
- This bypasses the bridge's existing retry policy, which was independent of the taxonomy shim. A transient CAPI
HttpResponseErrorsuch asDependencyFailure/server_errorwill now abort the entire agent turn on the first failure instead of retrying up to three times. Please retain_create_with_retry(and its tests) and remove only the taxonomy-specific patching.
response = client.chat.completions.create(**kwargs)
Sun Haoran (haoranpb)
marked this pull request as ready for review
August 6, 2026 11:08
Sun Haoran (haoranpb)
enabled auto-merge (squash)
August 6, 2026 11:12
martinsrui-msft
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up #756
Instead of handling the headers in BC-Bench, moved the logic upstream into
bc-eval, and uptake,bc-evalnow have those headers out of box. (see https://microsoft.ghe.com/bic/BC-LanguageModelTools/pull/69)The implementation of those headers belongs in
bc-eval, so the downstream (e.g. BC-Bench) does not need to handle them.