Decouple code-review from the BC PR Review runner - #795
Closed
Wenjie Fan (gggdttt) wants to merge 2 commits into
Closed
Decouple code-review from the BC PR Review runner#795Wenjie Fan (gggdttt) wants to merge 2 commits into
Wenjie Fan (gggdttt) wants to merge 2 commits into
Conversation
Restore generic Copilot and Claude comparisons for the shared code-review category while keeping BC PR Review as a dedicated production-fidelity runner. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up on Haoran's review of #774 by separating the
code-reviewevaluation contract from the system under test.--category code-reviewfor the generic GitHub Copilot CLI and Claude Code runners, backed by a strict sharedreview.jsonprompt contractbcbench run/evaluate pr-reviewcommands and move its integration tobcbench.agent.pr_reviewagent_nameand model metadata distinguish the runners, so no result migration is neededThe just-released
code-reviewrunner command remains as a hidden deprecated alias to avoid an immediate CLI break without presenting the category as a runner in public help.Validation
uv run ruff format <changed Python files>uv run ruff check <changed Python files>uv run ty check . --ignore=unresolved-import --exclude "notebooks/"uv run pytest -q(738 passed, 2 skipped)