Add new 'IObjectReference' tracking APIs - #1849
Closed
Sergio Pedri (Sergio0694) wants to merge 18 commits into
Closed
Sergio Pedri (Sergio0694) wants to merge 18 commits into
Sergio Pedri (Sergio0694) wants to merge 18 commits into
Conversation
Sergio Pedri (Sergio0694)
requested a review
from Manodasan Wignarajah (manodasanW)
October 26, 2024 18:52
Sergio Pedri (Sergio0694)
marked this pull request as ready for review
October 26, 2024 18:54
Sergio Pedri (Sergio0694)
force-pushed
the
user/sergiopedri/obj-ref-tracking
branch
from
October 26, 2024 18:59
4cf7522 to
2faa5ef
Compare
Sergio Pedri (Sergio0694)
force-pushed
the
user/sergiopedri/obj-ref-tracking
branch
from
October 28, 2024 23:42
cfebdfe to
d025d82
Compare
Sergio Pedri (Sergio0694)
marked this pull request as draft
January 10, 2025 14:57
Member
|
Probably want to retarget staging/2.3 |
Member
Author
|
Yup! Will retarget and rebase after #1843 is merged 🙂 |
Sergio Pedri (Sergio0694)
force-pushed
the
user/sergiopedri/obj-ref-tracking
branch
from
January 24, 2025 08:04
f0480fc to
602c79f
Compare
Sergio Pedri (Sergio0694)
changed the base branch from
staging/2.2
to
staging/2.3
January 24, 2025 08:04
Sergio Pedri (Sergio0694)
marked this pull request as ready for review
January 24, 2025 08:04
Member
Author
|
This is actually not dependent on the .NET 9 target, so I've just rebased, retargeted and published it 😄 |
Member
Author
|
Closing this for now, moved to 3.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another take on #1474. This ports and adapts
ReferenceTrackerfrom ComputeSharp.Main benefits:
Dispose()callsThis PR only adds the new APIs. We can update all internal and generated uses in a follow up.