Skip to content

Potential typo in sample_perspective: tgt_fov_max instead of tgt_fov_x_max #146

Description

@maoxindong123

Hi, thanks for your great work!

I was reading through the code and noticed a potential typo in the sample_perspective function. In this line:

tgt_fov_x_min, tgt_fov_max = max(np.deg2rad(fov_range_absolute_min), tgt_fov_x_min), min(np.deg2rad(fov_range_absolute_max), tgt_fov_x_max)

Should tgt_fov_max be tgt_fov_x_max, or did I misunderstand?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions