Skip to content

Adds nullable to double schema conversions (#589) - #628

Merged
Vincent Biret (baywet) merged 7 commits into
support/v1from
fix/port-589
Jan 2, 2025
Merged

Adds nullable to double schema conversions (#589)#628
Vincent Biret (baywet) merged 7 commits into
support/v1from
fix/port-589

Conversation

@baywet

Copy link
Copy Markdown
Member

port of #589 to the v1 branch

* Update double schema

* Update integration file tests

* Update release notes
… vscode

Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet

Copy link
Copy Markdown
Member Author

this PR also ports #593

Comment thread src/Microsoft.OpenApi.OData.Reader/Common/Constants.cs Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion on removing the property instead. Otherwise looks good from my end.

Signed-off-by: GitHub <noreply@github.com>
@sonarqubecloud

sonarqubecloud Bot commented Jan 2, 2025

Copy link
Copy Markdown

@baywet
Vincent Biret (baywet) merged commit de62bb0 into support/v1 Jan 2, 2025
@baywet
Vincent Biret (baywet) deleted the fix/port-589 branch January 2, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants