Adds action/function suffix to tag names for action/function operations - #641
Merged
Conversation
…is a an action or a function
Tim (timayabi2020)
requested review from
Andrew Omondi (andrueastman),
Vincent Biret (baywet),
Daniel Mbaluka (danielmbaluka),
Darrel (darrelmiller),
Gavin Barron (gavinbarron),
Irvine Sunday (irvinesunday),
Millicent Achieng (millicentachieng) and
Sam Xu (xuzhg)
as code owners
January 17, 2025 12:00
Vincent Biret (baywet)
requested changes
Jan 17, 2025
Vincent Biret (baywet)
left a comment
Member
There was a problem hiding this comment.
Please add a unit test for that behaviour.
Also:
- main is the branch for v2.x (currently in preview)
- support/v1 is the branch for 1.X (GA, what our tooling uses)
You'll need to port the fix (cherry-pick, not merge) to benefit it in the generation pipeline
…action or a function
Contributor
Author
|
Closing this in favor of another PR that targets support/v1 branch |
Member
|
Tim (@timayabi2020) you'll need to do both so the fix is also present in v2 when we release and there are no regressions. (unless it's already present in 2.X) |
Vincent Biret (baywet)
previously approved these changes
Jan 20, 2025
Member
|
Tim (@timayabi2020) I think some of the changes around the Id were missed here. |
|
Vincent Biret (baywet)
approved these changes
Jan 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #640
This PR is a follow up to #586 and it includes "Actions" or "Functions" as suffixes to the tag. This will