Clean up ARM64 popcount - #4695
Merged
Stephan T. Lavavej (StephanTLavavej) merged 5 commits intoJun 18, 2024
Merged
Conversation
Contributor
Author
|
Honestly, what I'm doing for ARM64EC here is uneducated guess. |
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jun 13, 2024
Closed
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for greatly simplifying this code! 😻 ✨ 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is both way simpler (don't need to use another intrinsics set) and better for codegen (as the previous version is only for 64-bits and does not take advantage of smaller parameter size).
I have not tested on actual ARM64 and ARM64EC.
Resolves #4683
Resolves #2129
Resolves llvm/llvm-project#50830