Repository navigation
Fix excessive comparisons in minmax algorithms - #6264
Open
Mirion (mirion-dev) wants to merge 10 commits into
Open
Mirion (mirion-dev) wants to merge 10 commits into
Mirion (mirion-dev) wants to merge 10 commits into
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Stephan T. Lavavej (StephanTLavavej)
requested changes
Apr 28, 2026
Copilot started reviewing on behalf of
Stephan T. Lavavej (StephanTLavavej)
April 28, 2026 23:00
View session
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to [alg.min.max#32], the algorithms should perform at most
max(floor(3/2 (N−1)),0)comparisons, but the current implementations ofstd::{ranges::}minmax_elementviolate this requirement whenNis even. This can be reproduced with the added test cases in this PR.Although
std::ranges::minmaxdoes not violate it because its upper bound is(3/2) N[alg.min.max#23], I have optimized it as well.