Skip to content

Improve test reliability and add force exit option #2677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robgruen merged 3 commits into from
Jul 15, 2026
+11 −5
Merged

Improve test reliability and add force exit option #2677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
baf3793
allow test mode to not probe for runningAgentServers
robgruen Jul 15, 2026
ede4ebe
flakey test fix
robgruen Jul 15, 2026
51732b5
added forceexit to live tests
robgruen Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ts/packages/defaultAgentProvider/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"prettier": "prettier --check . --ignore-path ../../.prettierignore",
"prettier:fix": "prettier --write . --ignore-path ../../.prettierignore",
"test": "pnpm run jest-esm",
"test:live": "pnpm run jest-esm --testPathPattern=\".*[.]test[.]js\"",
"test:live": "pnpm run jest-esm --testPathPattern=\".*[.]test[.]js\" --forceExit",
"test:live:debug": "node --inspect-brk --no-warnings --experimental-vm-modules ./node_modules/jest/bin/jest.js --testPathPattern=\".*\\.test\\.js\"",
"test:local": "pnpm run jest-esm --testPathPattern=\".*[.]spec[.]js\" --testPathIgnorePatterns=\"grammarNfaIntegration[.]spec[.]js\"",
"test:local:debug": "node --inspect-brk --no-warnings --experimental-vm-modules ./node_modules/jest/bin/jest.js --testPathPattern=\".*\\.spec\\.js\"",
Expand Down
5 changes: 1 addition & 4 deletions ts/packages/defaultAgentProvider/test/data/translate-history-e2e.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,7 @@
"schemaName": "browser.lookupAndAnswer",
"actionName": "lookupAndAnswerInternet",
"parameters": {
"originalRequest": "look up the ingredient for shepherd's pie for me please",
"internetLookups": [
"ingredient for shepherd's pie"
]
"originalRequest": "look up the ingredient for shepherd's pie for me please"
}
},
"partial": true
Expand Down
9 changes: 9 additions & 0 deletions ts/packages/shell/src/main/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,10 +153,19 @@ async function detectRunningAgentServer(port: number): Promise<boolean> {
// latter would fail to acquire the shared instance-directory lock and abort
// startup with "Another agent-server (or shell) is already using the instance
// directory".
//
// Never probe in test mode (--test). The smoke/e2e harness launches its own
// isolated instance (per-worker INSTANCE_NAME/PORT, --mock-greetings) and must
// stay hermetic: if the probe found any agent-server on the default port — e.g.
// the detached background server the CLI smoke step leaves on 8999, or a
// developer's dogfooding session — the test shell would connect to that foreign
// server instead of hosting its own, never reach the expected ready state, and
// time out.
let effectiveConnect = parsedArgs.connect;
if (
effectiveConnect === undefined &&
!isProd &&
!isTest &&
parsedArgs.data === undefined &&
!parsedArgs.clean &&
!parsedArgs.reset &&
Expand Down
Loading