Improve test reliability and add test mode options#2678
Merged
Conversation
curtisman
reviewed
Jul 15, 2026
curtisman
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains several improvements to the test infrastructure and reliability for the shell and agent provider packages. The changes focus on making test runs more robust, preventing race conditions, and ensuring that tests do not fail due to slow shutdowns or interference from other running instances.
Test infrastructure and reliability improvements:
@session cleartest to wait for the session reinitialization to fully complete and verify the success message before shutting down, preventing shutdown race conditions that could cause test timeouts. [1] [2]closeInstancehelper to force-kill the process and log a warning if graceful shutdown exceeds the timeout, instead of failing the test, making tests more resilient to slow or hung shutdowns.