Remove stray console.log and dead test:live placeholder#2679
Open
curtisman wants to merge 2 commits into
Open
Conversation
- matchRequest.ts: drop the '[Cache Validation Success] Wildcard match validated and accepted' console.log. The nearby debugConstValidation call already covers this path. - config/package.json: remove the 'test:live' script whose body is just 'echo "no live tests in phase 1"'. It served no purpose and made 'npm run test:live -ws' noisier.
robgruen
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small cleanups.
What
1. Drop a stray
console.login cache validation.getValidatedMatchesinmatchRequest.tslogs[Cache Validation Success] Wildcard match validated and acceptedto the console every time a wildcard match is accepted. The adjacentdebugConstValidationcall already reports the same event on the debug channel, so theconsole.logis just noise (and it bypasses thedebuggating).2. Remove a dead
test:liveplaceholder inpackages/config.ts/packages/config/package.jsonhad:It served no purpose - the package has no live tests - and it made recursive
pnpm run test:liveoutput noisier for no benefit. Dropping it lets pnpm skip the package cleanly.Files touched
ts/packages/dispatcher/dispatcher/src/translation/matchRequest.ts- remove oneconsole.log.ts/packages/config/package.json- remove thetest:livescript.