Fix sidebar header tree creation - #3021
Merged
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-plant-05c166c10-3021.centralus.5.azurestaticapps.net |
Jake Bailey (jakebailey)
approved these changes
Jun 5, 2024
Jake Bailey (jakebailey)
left a comment
Member
There was a problem hiding this comment.
Thanks, this definitely looks better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think the depth structure of the document's sidebar represents the depth of the headers in the document very well.
This makes it a little difficult to understand the content.
For example, for "Narrowing" in the handbook, the header in the document looks like this
In the sidebar on the current page, it looks like this
I think this makes more sense. because I think all the h1s should be 1-depth, and the first h2 should be 1-depth.
I've also found cases like this with "template-literal-types", "conditional-types", etc.