JSX formatting does not de-indent closing tag with text body

[mjbvz]

From microsoft/vscode#40454 (comment)

TypeScript Version: 2.7.0-dev.20171214

Code

(
    <div>
        text
        </div>
)

Run format

Expected behavior:

(
    <div>
        text
    </div>
)

Actual behavior:
No change. Content remains:

(
    <div>
        text
        </div>
)

The </div> is de-indented if the body is a tag instead of text:

(
    <div>
        <span />
        </div>
)

[srolel]

Mohamed Hegazy (@mhegazy) I've been working on this, and it looks like this doesn't get formatted because the linebreak and whitespace between text and </div> are consumed by the scanner as a part of the SyntaxKind.JsxText token. I have a fix I can submit but I want to make sure this would be the right behavior (removing the whitespace). This does agree with JSX compilation, where the compiled string does not include any leading/trailing whitespace, so this would not have any effect on compiled code, as it should.

The fix is along the lines of stopping after the linebreak, which will make the closing </div> tag have that whitespace as leadingTrivia which will get formatted correctly.

[mhegazy]

sounds reasonable. I have not looked at the formatting scanner in a while, so i will need to look at the change, and look around to see if i can poke holes into the fix.