No import completions from npm packages

[DanielRosenwasser]

No named import completions for module

npm init --yes
npm install danger
tsc --init

Now create a .ts file

import { danger, fail, } from "danger";

pe/**/

Request completions at /**/

Expected: Completion for peril.
Actual: No completion.

[mhegazy]

There are few issues here.. First module augmentations seems to diable completions alltogather.. here is a simpler repro:

// c.ts
export var y = 0;

// b.ts
export { };

declare module "./c" {
    export var x;
}

// a.ts

import * as B from "./b";

|  // expect `x` and `y` to show up here. 

The other issue here is in the declaration file for danger is wrong, and is not flagged as such.. the module is declared as:

import * as GitHub from "@octokit/rest";
declare module "danger" {
    ...
}

which should be an error really, since the module augmentation is invalid.. not sure why we are not erroring there..

the file should rather be written as a module, or as:

declare module "danger" {
    import * as GitHub from "@octokit/rest";
     ...
}

[mhegazy]

@DanielRosenwasser can you follow up with the danger authors to fix their declaration file.

[DanielRosenwasser]

Psst @orta

[orta]

Ah, yeah, perfect, thanks!

[mhegazy]

@Andy-MS do you know why was the invalid augmentation error not shown in this file?

Made a new issue for that #24307