Experiment: Always report useDefineForClassFields-related errors even when disabled

[rbuckton]

This is an experiment to establish a rough estimate of how frequently projects in the wild depend on the initializer order for TypeScript "Parameter Property Initializers" feature when used in conjunction with useDefineForClassFields: false.

Note that this will only catch cases where projects have an ordering dependency that would be reported as a use-before-definition error by the compiler when useDefineForClassFields is enabled.

[rbuckton]

@typescript-bot test top1000

[typescript-bot]

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
test top1000	✅ Started	👀 Results

[typescript-bot]

@rbuckton Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59623/merge:

Something interesting changed - please have a look.

Details

google/blockly

2 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

• error TS2729: Property 'value_' is used before its initialization.
  • core/field_checkbox.ts#L47

[trevorade]

FYI, this commit is most likely missing a change to make isBlockScopedNameDeclaredBeforeUse ignore emitStandardClassFields when called from checkPropertyNotUsedBeforeDeclaration. I needed to also update that code to make TS2729 universally be emitted.