Fix image leaks in the tests causing failures in "WslcSdkTests::ImageProgressCallback"#40888
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Windows WSLC SDK test suites to proactively delete registry-pulled images at test scope-exit, preventing leftover image layers from prior runs from contaminating subsequent runs (notably scenarios that exercise image pull progress callbacks).
Changes:
- Add scope-exit cleanup in WinRT-based image pull/auth tests to delete the test image via
m_defaultSession.DeleteImage(...)(errors swallowed). - Add scope-exit cleanup in C-API based image pull/auth tests to delete the test image via
WslcDeleteSessionImage(...)(failures logged).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/windows/WslcSdkWinRTTests.cpp | Adds SCOPE_CLEANUP image deletion to avoid leaked images between WinRT test runs. |
| test/windows/WslcSdkTests.cpp | Adds wil::scope_exit_log image deletion to avoid leaked images between C-API test runs. |
benhillis
approved these changes
Jun 24, 2026
JohnMcPMS
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This change solves various image layer leaks in the tests that cause the
WslcSdkTests::ImageProgressCallbackto fail if ran from a storage of a previous test session.PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed