Drop hardcoded /en-us/ locale from Microsoft Learn doc links - #193
Open
Chiara Mooney (chiaramooney) wants to merge 1 commit into
Open
Drop hardcoded /en-us/ locale from Microsoft Learn doc links#193Chiara Mooney (chiaramooney) wants to merge 1 commit into
Chiara Mooney (chiaramooney) wants to merge 1 commit into
Conversation
Microsoft Learn negotiates locale server-side, so locale-less URLs redirect readers to their preferred language. Pinning /en-us/ forced English docs for everyone. Adds a test guarding against regressions. Fixes #190 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
VSIX Build
Updated 2026-08-20 23:18:51 UTC · commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #190
What
Every "Learn more" link in the manifest editor webview hardcoded the
/en-us/locale segment, pinning Microsoft Learn docs to English for all readers. Microsoft Learn negotiates locale server-side, so a locale-less URL 302-redirects each reader to their preferred language, while anen-usURL stays English.Changes
/en-us/from all 17 Learn links (15 unique URLs):src/manifest-editor/webview-content.ts— 14 linkssrc/manifest-editor/webview-script-applications.ts— 3 linkssrc/test/docs-links.test.ts, a regression guard that scanssrc/and fails if any file reintroduces a locale-pinnedlearn.microsoft.com/xx-xx/URL.Legitimate BCP-47
en-uslanguage tags (appxmanifestResource Language="en-us", validator error text, test fixtures, README) are untouched — the guard regex only matcheslearn.microsoft.comURLs.Validation
npm run pretest(tsc + eslint) — clean, only pre-existing warnings