[monobuild] Gate public symbol publish behind PublishPublicSymbols param#6644
Draft
kythant wants to merge 1 commit into
Draft
[monobuild] Gate public symbol publish behind PublishPublicSymbols param#6644kythant wants to merge 1 commit into
kythant wants to merge 1 commit into
Conversation
Add a PublishPublicSymbols parameter (default true) to the three Foundation symbol-publish step templates (Installer, VSIX, PackTransportPackage) and thread it into the InnerParams splatted to WindowsAppSDK-PublishSymbol-Wrapper.yml, which forwards to WindowsAppSDK-PublishSymbol-Steps.yml. The leaf gates the public SymWeb/MSDL publish on and(IsOfficial, PublishPublicSymbols). Default true preserves standalone per-component pipeline behavior; the monobuild passes false while the public symbol-publish service connection is being sorted.
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
PublishPublicSymbolsparameter (defaulttrue) to the three Foundation symbol-publish step templates and threads it into theInnerParamsobject splatted toWindowsAppSDK-PublishSymbol-Wrapper.yml, which forwards toWindowsAppSDK-PublishSymbol-Steps.yml:build/AzurePipelinesTemplates/WindowsAppSDK-BuildInstaller-Steps.ymlbuild/AzurePipelinesTemplates/WindowsAppSDK-BuildVSIX-Steps.ymlbuild/AzurePipelinesTemplates/WindowsAppSDK-PackTransportPackage-Steps.ymlWhy
The leaf template gates the public SymWeb/MSDL symbol publish on
and(IsOfficial, PublishPublicSymbols). On the Official mono-build the public publish for the Installer, VSIX, and Foundation transport package currently runs unconditionally, and it needs to be turned off while the public symbol-publish service connection is being sorted. Defaulttruepreserves existing standalone per-component pipeline behavior; only the mono-build passesfalse.Merge order (cross-repo)
This change adds
PublishPublicSymbolsto theInnerParamsthat reach the leaf'sPublishPublicSymbolsparameter, which is introduced by the monorepo leaf-param PR. Merge in this order:Validation
Validated end to end via the Official mono-build (ADO OS/WinAppSDK def 196647) pipeline preview, with this branch supplied as the
WindowsAppSDKFoundationresource and the monorepo threading branch asself:PublishPublicSymbols=false-> 0 "Publish symbols to SymWeb and MSDL" tasks in the compiled pipeline (down from 6)PublishPublicSymbols=true-> 6 such tasksPublish private symbols to internal server) is unchanged: 7 instances, always on.