Skip to content

[dotnet-port-fixes] Add checkpointed hosted-agent identity parity - #803

Merged
George Adams (gdams) merged 2 commits into
mainfrom
copilot/dotnet-port-fixes-stable-agent-checkpoints-790088ca8b792564
Aug 7, 2026
Merged

[dotnet-port-fixes] Add checkpointed hosted-agent identity parity#803
George Adams (gdams) merged 2 commits into
mainfrom
copilot/dotnet-port-fixes-stable-agent-checkpoints-790088ca8b792564

Conversation

@michelle-clayton-work

Copy link
Copy Markdown
Contributor

Summary

Ports the .NET checkpoint-identity regression coverage from 6a3d5352042959eb276dc52e1e7f69a6fe5e4e8a by adding Go tests that prove workflow-agent sessions only resume across reconstruction when hosted inner agents keep stable identities. The change also adds matching checkpoint sample guidance explaining that hosted agents must be recreated with the same agent ID and, when set, the same name so hosted executor IDs remain compatible with saved checkpoints.

Ported .NET PRs

Breaking Changes

No.

Tests and Examples

  • Added TestNew_SerializedSessionWithStableHostedAgentIdentity_ResumesAcrossReconstruction
  • Added TestNew_SerializedSessionWithUnstableHostedAgentIdentity_FailsAcrossReconstruction
  • Added TestNew_SerializedSessionWithRenamedHostedAgent_FailsAcrossReconstruction
  • Updated examples/03-workflows/checkpoint/checkpoint_and_rehydrate/main.go with hosted-agent checkpoint identity guidance
  • Ran go test ./workflow/agentworkflow -run 'TestNew_SerializedSession(WithStableHostedAgentIdentity_ResumesAcrossReconstruction|WithUnstableHostedAgentIdentity_FailsAcrossReconstruction|WithRenamedHostedAgent_FailsAcrossReconstruction)$'

Notes

  • Upstream commit inspected: 6a3d5352042959eb276dc52e1e7f69a6fe5e4e8a
  • Recent prefixed Go tracking PRs checked included #459, #677, #583, #582, #539, #538, #445, and #395; none covered this checkpointed hosted-agent identity case.
  • The worktree contains an unrelated untracked file at .github/agents/port-candidate-selector.agent.md; it is not part of this PR.

Generated by .NET to Go Fixes and Test Porting Agent · gpt54 · 346.6 AIC · ⌖ 23.9 AIC · ⊞ 24.2K ·

Closes #791

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Note

This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.

@github-actions github-actions Bot added the parity-approved Go API consistency review found no parity issues label Aug 7, 2026
@github-actions

This comment has been minimized.

@gdams
George Adams (gdams) added this pull request to the merge queue Aug 7, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Aug 7, 2026
@gdams

Copy link
Copy Markdown
Member

Copilot resolve the merge conflicts in this pull request

…ixes-stable-agent-checkpoints-790088ca8b792564

# Conflicts:
#	workflow/agentworkflow/workflow_test.go

Co-authored-by: gdams <20224954+gdams@users.noreply.github.com>

Copilot AI commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Copilot resolve the merge conflicts in this pull request

Merge conflicts resolved in 1f40b0f.

main had already landed equivalent checkpoint-identity regression tests (TestNew_SerializedSessionResumesHostedAgentCheckpointAcrossReconstruction, ...FailsAcrossReconstructionWithoutStableHostedAgentID, ...FailsAcrossReconstructionWhenHostedAgentNameChanges), so I dropped this branch's duplicate tests and helpers in workflow/agentworkflow/workflow_test.go in favor of main's versions. The remaining net change is the hosted-agent checkpoint identity guidance comment in examples/03-workflows/checkpoint/checkpoint_and_rehydrate/main.go.

Verified with go build ./... and go test ./... — all passing.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Parity Review: ✅ Approved

This PR ports regression test coverage and matching sample comment guidance from upstream .NET commit 6a3d5352 (microsoft/agent-framework#7415).

Scope: Only workflow/agentworkflow/workflow_test.go (new tests) and a 4-line comment block in examples/03-workflows/checkpoint/checkpoint_and_rehydrate/main.go are changed. No exported Go APIs are added, removed, or modified.

Cross-repo alignment: The hosted-agent checkpoint identity constraint (stable agent ID + name → stable executor ID) is semantically aligned with the upstream .NET regression tests being ported. The sample comment faithfully reflects the same guidance present in the .NET reference.

Verdict: No parity issues found. No public API surface changed — public-api-change label is not warranted.

Generated by Go API Consistency Review Agent for #803 · sonnet46 · 17.7 AIC · ⌖ 5.56 AIC · ⊞ 5.7K ·

Merged via the queue into main with commit d26b965 Aug 7, 2026
21 checks passed
@gdams
George Adams (gdams) deleted the copilot/dotnet-port-fixes-stable-agent-checkpoints-790088ca8b792564 branch August 7, 2026 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parity-approved Go API consistency review found no parity issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[dotnet-port-fixes] Add checkpointed hosted-agent identity parity

4 participants