[dotnet-port-fixes] Add checkpointed hosted-agent identity parity - #803
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Note
This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.
This comment has been minimized.
This comment has been minimized.
|
Copilot resolve the merge conflicts in this pull request |
…ixes-stable-agent-checkpoints-790088ca8b792564 # Conflicts: # workflow/agentworkflow/workflow_test.go Co-authored-by: gdams <20224954+gdams@users.noreply.github.com>
Merge conflicts resolved in
Verified with |
Parity Review: ✅ ApprovedThis PR ports regression test coverage and matching sample comment guidance from upstream .NET commit Scope: Only Cross-repo alignment: The hosted-agent checkpoint identity constraint (stable agent ID + name → stable executor ID) is semantically aligned with the upstream .NET regression tests being ported. The sample comment faithfully reflects the same guidance present in the .NET reference. Verdict: No parity issues found. No public API surface changed —
|
Summary
Ports the .NET checkpoint-identity regression coverage from
6a3d5352042959eb276dc52e1e7f69a6fe5e4e8aby adding Go tests that prove workflow-agent sessions only resume across reconstruction when hosted inner agents keep stable identities. The change also adds matching checkpoint sample guidance explaining that hosted agents must be recreated with the same agent ID and, when set, the same name so hosted executor IDs remain compatible with saved checkpoints.Ported .NET PRs
Breaking Changes
No.
Tests and Examples
TestNew_SerializedSessionWithStableHostedAgentIdentity_ResumesAcrossReconstructionTestNew_SerializedSessionWithUnstableHostedAgentIdentity_FailsAcrossReconstructionTestNew_SerializedSessionWithRenamedHostedAgent_FailsAcrossReconstructionexamples/03-workflows/checkpoint/checkpoint_and_rehydrate/main.gowith hosted-agent checkpoint identity guidancego test ./workflow/agentworkflow -run 'TestNew_SerializedSession(WithStableHostedAgentIdentity_ResumesAcrossReconstruction|WithUnstableHostedAgentIdentity_FailsAcrossReconstruction|WithRenamedHostedAgent_FailsAcrossReconstruction)$'Notes
6a3d5352042959eb276dc52e1e7f69a6fe5e4e8a#459,#677,#583,#582,#539,#538,#445, and#395; none covered this checkpointed hosted-agent identity case..github/agents/port-candidate-selector.agent.md; it is not part of this PR.Closes #791