Skip to content

.NET: Disable failing durable function integration tests - #6731

Merged
SergeyMenshykh merged 1 commit into
microsoft:mainfrom
SergeyMenshykh:sergeymenshykh-disable-durable-function-integration-tes
Jun 25, 2026
Merged

SergeyMenshykh merged 1 commit into
microsoft:mainfrom
SergeyMenshykh:sergeymenshykh-disable-durable-function-integration-tes

Conversation

@SergeyMenshykh

@SergeyMenshykh SergeyMenshykh commented Jun 25, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Disables two persistently failing durable function integration tests:

  • LongRunningToolsSampleValidationAsync
  • ReliableStreamingSampleValidationAsync

Both tests in ConsoleAppSamplesValidation.cs are skipped via the Skip parameter on their [RetryFact] attributes.

Motivation

These tests have been consistently failing in CI, blocking other PRs. See the failed run: https://github.com/microsoft/agent-framework/actions/runs/28161194756/job/83401892188

Changes

  • Added Skip reason to [RetryFact(2, 5000)] for both tests, referencing the failing CI run for traceability.

Copilot AI review requested due to automatic review settings June 25, 2026 10:49
@moonbox3 Evan Mattson (moonbox3) added the .NET Usage: [Issues, PRs], Target: .Net label Jun 25, 2026
@github-actions github-actions Bot changed the title Disable failing durable function integration tests .NET: Disable failing durable function integration tests Jun 25, 2026
@SergeyMenshykh SergeyMenshykh self-assigned this Jun 25, 2026
@SergeyMenshykh SergeyMenshykh moved this to In Review in Agent Framework Jun 25, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated Code Review

Reviewers: 5 | Confidence: 93% | Result: All clear

Reviewed: Correctness, Security Reliability, Test Coverage, Failure Modes, Design Approach


Automated review by SergeyMenshykh's agents

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR disables two persistently failing Durable Task console-sample integration tests in the .NET test suite by marking them skipped, unblocking CI for unrelated changes.

Changes:

  • Added Skip = "...reason..." to the [RetryFact(2, 5000)] attributes for LongRunningToolsSampleValidationAsync.
  • Added Skip = "...reason..." to the [RetryFact(2, 5000)] attributes for ReliableStreamingSampleValidationAsync.

@rogerbarreto

Copy link
Copy Markdown
Member

Suggest creating an issue to track the failures and address the root cause for a more consistent test check in the future.

@SergeyMenshykh SergeyMenshykh left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated both skip reasons to reference the tracking issue #6732.

@SergeyMenshykh
SergeyMenshykh added this pull request to the merge queue Jun 25, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 25, 2026
@SergeyMenshykh
SergeyMenshykh force-pushed the sergeymenshykh-disable-durable-function-integration-tes branch from 67e2c70 to a984c80 Compare June 25, 2026 14:18
@SergeyMenshykh
SergeyMenshykh enabled auto-merge June 25, 2026 14:20
Skip LongRunningToolsSampleValidationAsync and ReliableStreamingSampleValidationAsync
tests that are persistently failing in CI.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@SergeyMenshykh
SergeyMenshykh force-pushed the sergeymenshykh-disable-durable-function-integration-tes branch from a984c80 to d9b6e3f Compare June 25, 2026 14:29
@SergeyMenshykh
SergeyMenshykh added this pull request to the merge queue Jun 25, 2026
Merged via the queue into microsoft:main with commit 802fe13 Jun 25, 2026
27 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in Agent Framework Jun 25, 2026

This branch was previously deployed

1 inactive deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

.NET Usage: [Issues, PRs], Target: .Net

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants