Skip to content

.NET: Fix snake_case argument names in Harness file tool descriptions - #7731

Merged
westey (westey-m) merged 2 commits into
mainfrom
copilot/fix-harness-file-tool-descriptions
Aug 18, 2026
Merged

westey (westey-m) merged 2 commits into
mainfrom
copilot/fix-harness-file-tool-descriptions

Conversation

Copilot AI commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Motivation & Context

AIFunctionFactory generates tool schemas from C# parameter names (camelCase), but several [Description] attributes on FileAccessProvider/FileMemoryProvider tools referred to those arguments using snake_case names. A model following the description would emit an argument name the schema doesn't recognize, so the value silently fails to bind and the tool runs without it (e.g., a missing filter) instead of surfacing an error.

Description & Review Guide

  • What are the major changes?
    • Updated [Description] text on file_access_ls / file_memory_ls to say globPattern instead of glob_pattern.
    • Updated [Description] text on file_memory_grep to say globPattern instead of glob_pattern (the file_access_grep description already used "glob pattern" generically and needed no change).
    • Updated [Description] text on file_access_replace / file_memory_replace to say oldString, newString, replaceAll instead of old_string, new_string, replace_all.
    • Left replace_lines's line_number/new_line untouched — those parameters carry explicit [JsonPropertyName] attributes, so the schema genuinely uses snake_case there and the existing description is correct.
  • What is the impact of these changes?
    • Description text only; no schema, parameter, or behavioral changes. Tool argument names exposed to models are unchanged — this just makes the description match what already exists.
  • What do you want reviewers to focus on?
    • Confirm no other snake_case/camelCase mismatches remain across the two providers.

Related Issue

Contribution Checklist

  • The code builds clean without any errors or warnings
  • All unit tests pass, and I have added new tests where possible
  • The PR follows the Contribution Guidelines
  • This PR is linked to an issue and there is no other open PR for this issue (see Related Issue above).
  • This is not a breaking change. If it is a breaking change, add the breaking change label (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.

Copilot AI balanced review requested due to automatic review settings August 18, 2026 15:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Co-authored-by: westey-m <164392973+westey-m@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix harness file tool descriptions for argument naming consistency .NET: Fix snake_case argument names in Harness file tool descriptions Aug 18, 2026
@westey-m
westey (westey-m) marked this pull request as ready for review August 18, 2026 16:56
Copilot AI temporarily deployed to github-app-auth August 18, 2026 16:56 Inactive
Copilot AI temporarily deployed to github-app-auth August 18, 2026 16:56 Inactive
Copilot AI temporarily deployed to github-app-auth August 18, 2026 16:56 Inactive
Copilot AI temporarily deployed to github-app-auth August 18, 2026 16:56 Inactive
@westey-m
westey (westey-m) added this pull request to the merge queue Aug 18, 2026
This was referenced Sep 10, 2026
@baywet
Vincent Biret (baywet) deleted the copilot/fix-harness-file-tool-descriptions branch September 17, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

.NET Usage: [Issues, PRs], Target: .Net

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.NET: [Bug]: Harness file tool descriptions name arguments in snake_case, but the generated schema is camelCase

6 participants