Skip to content

fix: no-op on already-cached records in covert_insert_records_to_cache #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sheikh Nasrullah (snash4) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: no-op on already-cached records in covert_insert_records_to_cache #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/nodes/leaf_node.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,9 @@ impl LeafNode {
meta.set_op_type(OpType::Phantom);
}
OpType::Cache | OpType::Phantom => {
unreachable!("Base page should not have op type: {:?}", op_type);
// Already in cache state — nothing to convert.

@snash4 Sheikh Nasrullah (snash4) Aug 24, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already in cache state — e.g. a page restored from a CPR snapshot that was
promoted at snapshot time, then re-promoted by a write after recovery.
Nothing to convert. Mirrors convert_cache_records_to_insert, which already handles the symmetric case as a no-op.

// Mirrors convert_cache_records_to_insert, which already
// tolerates the already-converted case as a no-op.
}
};

Expand Down