Skip to content

Preserve sub-millisecond event timestamp precision - #1516

Merged
bmehta001 merged 3 commits into
microsoft:mainfrom
bmehta001:bhamehta/fix-event-timestamp-precision
Aug 5, 2026
Merged

Preserve sub-millisecond event timestamp precision#1516
bmehta001 merged 3 commits into
microsoft:mainfrom
bmehta001:bhamehta/fix-event-timestamp-precision

Conversation

@bmehta001

Copy link
Copy Markdown
Contributor

Summary

  • preserve nanosecond-derived 100 ns precision for default POSIX event timestamps
  • use GetSystemTimePreciseAsFileTime on Windows when available, with a Windows 7-compatible fallback
  • add regression coverage for POSIX timestamps retaining sub-millisecond ticks

Fixes #1514.

Validation

  • git diff --check passed
  • Fresh Windows CMake configuration succeeded
  • The unit-test build was blocked by existing configuration issues: missing gtest/gtest.lib and /WX failures from pre-existing HAVE_MAT_AI macro redefinition / exception-mode warnings

Use precise wall-clock time where available and retain nanosecond-derived 100 ns ticks on POSIX so record.time no longer truncates every event to milliseconds. Add regression coverage for POSIX timestamp precision.\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>\nCopilot-Session: 05d1030e-75b0-447f-9856-65091d59a97f
@bmehta001
bmehta001 requested a review from a team as a code owner August 3, 2026 19:13
@bmehta001 bmehta001 self-assigned this Aug 3, 2026
Resolve GetSystemTimePreciseAsFileTime once instead of repeating module and symbol lookups for every event timestamp.\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>\nCopilot-Session: 05d1030e-75b0-447f-9856-65091d59a97f
@bmehta001
bmehta001 merged commit 6c19c2f into microsoft:main Aug 5, 2026
26 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Event timestamps (record.time) only have millisecond resolution despite 100ns tick field

2 participants