Migrate GitHub CI off VS 2022, add C++20 module test, dynamic v143/v145 toolset#1601
Open
Copilot wants to merge 2 commits into
Open
Migrate GitHub CI off VS 2022, add C++20 module test, dynamic v143/v145 toolset#1601Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Copilot created this pull request from a session on behalf of
DefaultRyan
June 24, 2026 00:43
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this all about?
The
windows-2025runner no longer ships the VS 2022 (v143) build tools, breaking every CI leg pinned to it. This migrates GitHub Actions to VS 2026 / v145 while keeping the OneBranch (VS 2022) pipelines buildable via a toolset that adapts to the available Visual Studio..github/workflows/ci.ymlwindows-2025+v143toolchain from the build, test, and nuget-test matrices;windows-2025-vs2026+v145is now the sole MSVC toolset.windows-latestjobs (build-msvc-natvis,build-nuget) towindows-2025-vs2026; natvis passesPlatformToolset=v145explicitly.test_cpp20_moduleto the test matrix, excludingclang-cl(C++20 named modules require MSVC v145).Directory.Build.Propsv143, upgraded tov145whenVisualStudioVersion >= 18.0. The base-plus-override keeps a valid value ifVisualStudioVersionis unset.test/nuget/TestProxyStub/TestProxyStub.vcxproj<PlatformToolset>so it inherits the dynamic default (v143 on OneBranch, v145 on VS 2026).Docs
.github/instructions/cppwinrt.instructions.mdto describe the VisualStudioVersion-based toolset selection.The OneBranch / ADO pipelines under
.pipelines/*are intentionally untouched, as those images update on a different cadence; the dynamic default is what lets them keep building the non-module projects on v143.