This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Fix Json serializer reflection - #433
Closed
David Bennett (dkbennett) wants to merge 1 commit into
Closed
Conversation
David Bennett (dkbennett)
requested review from
a team,
Kristen Schau (krschau) and
Vineeth Thomas Alex (vineeththomasalex)
August 16, 2024 18:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Sets JsonSerializer reflection default back to .Net 7 compat.
References and relevant issues
Same fix in Azure Extension Repo: microsoft/DevHomeAzureExtension#135
Detailed description of the pull request / Additional comments
Migration to .Net 8 changed the Json Serializer reflection default. This sets it back to .Net 7 for compat. There may be work here in the future to be able to disable this, but this will get the extension working again.
Note that this does not repro on Debug builds, must build Release to see the bug and verify fix.
Validation steps performed
PR checklist