Basic orchestration and activity execution logs - #405
Merged
Merged
Conversation
Chris Gillum (cgillum)
requested review from
halspang,
Jacob Viau (jviau) and
Naiyuan Tian (nytian)
March 31, 2025 22:44
Phillip Hoff (philliphoff)
previously approved these changes
Mar 31, 2025
Jacob Viau (jviau)
previously approved these changes
Apr 1, 2025
Jacob Viau (jviau)
left a comment
Member
There was a problem hiding this comment.
Good to have more logging. Do we have plans for distributed tracing in this library directly? These specific logs are more valuable as spans, as that will capture all of the same information but in a more usable way.
No harm in having these logs as well though - but I suggest putting the log level to Debug as if spans are ever added, these would be lower importance.
…into cgillum/log-improvements
Chris Gillum (cgillum)
dismissed stale reviews from Jacob Viau (jviau) and Phillip Hoff (philliphoff)
via
April 2, 2025 00:28
0d5163e
Jacob Viau (jviau)
requested changes
Apr 2, 2025
Jacob Viau (jviau)
previously approved these changes
Apr 2, 2025
halspang
reviewed
Apr 2, 2025
halspang
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're missing some basic execution logs in this SDK. For Azure Functions, this was okay because the Functions host and worker layer would sufficiently take care of logging. However, for standalone use, the base logging was insufficient.
This PR adds basic execution starting, completion, and failure logs for orchestrations and activities.