Fix nil pointer dereference when consuming events - #48
Merged
Chris Gillum (cgillum) merged 2 commits intoDec 14, 2023
Merged
Chris Gillum (cgillum) merged 2 commits into
Chris Gillum (cgillum) merged 2 commits into
Conversation
If an event is received after the internal timer waiting for it has elapsed, it should be placed into the pending events queue to be handled by the next WaitForSingleEvent invocation. However, the internal timer expiration callback does not reset the pending task list correctly, causing the event consumer to attempt to dereference an element of an empty list. This change adjusts the logic of the timer to completely eradicate the list from the pending event key map when it's empty, which matches the behavior of other orchestrator cleanup routines.
Contributor
Author
|
@microsoft-github-policy-service agree |
Chris Gillum (cgillum)
approved these changes
Dec 14, 2023
Chris Gillum (cgillum)
left a comment
Member
There was a problem hiding this comment.
Thanks Noah Fontes (@impl) for this PR contribution! The change looks good to me.
Noah Fontes (impl)
deleted the
fix-pending-task-cleanup-after-timeout
branch
December 14, 2023 07:49
Merged
Fabian Martinez (famarting)
pushed a commit
to famarting/durabletask-go
that referenced
this pull request
Oct 3, 2025
Create vanity `workflow` client
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an event is received after the internal timer waiting for it has elapsed, it should be placed into the pending events queue to be handled by the next
WaitForSingleEventinvocation. However, the internal timer expiration callback does not reset the pending task list correctly, causing the event consumer to attempt to dereference an element of an empty list.This change adjusts the logic of the timer to completely eradicate the list from the pending event key map when it's empty, which matches the behavior of other orchestrator cleanup routines.