Orchestration ID reuse policies - #51
Merged
Merged
Conversation
create alias for protos type update test move duplicate code outside backend implementation update paramter name
7 tasks done
kaibocai (kaibocai)
marked this pull request as ready for review
December 15, 2023 18:04
Member
Author
|
tag Alessandro (Ale) Segala (@ItalyPaleAle) , Ryan Lettieri (@RyanLettieri) for review. |
Alessandro (Ale) Segala (ItalyPaleAle)
approved these changes
Dec 15, 2023
Chris Gillum (cgillum)
left a comment
Member
There was a problem hiding this comment.
A few questions from me:
kaibocai (kaibocai)
force-pushed
the
kaibocai/reuse-id-dapr
branch
2 times, most recently
from
December 15, 2023 21:50
76c6eeb to
fde7991
Compare
simplify status check update tests clean up fix test
kaibocai (kaibocai)
force-pushed
the
kaibocai/reuse-id-dapr
branch
from
December 15, 2023 21:54
fde7991 to
12222af
Compare
Chris Gillum (cgillum)
approved these changes
Dec 18, 2023
Chris Gillum (cgillum)
left a comment
Member
There was a problem hiding this comment.
LGTM! Glad to have this change! Let's wait to merge until the Dapr PR which uses it is also signed off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up PR for #46. It include some updates to support reuse ID policy in dapr workflow
Related issue #42