Updates for latest Durable Task OOProc protocols - #19
Merged
Merged
Conversation
- Renamed ErrorDetails to FailureDetails - Made FailureDetails a property of OrchestrationMetadata - Removed JSON serialization of errors - Split error testing into new JUnit class - Misc. cleanup
kaibocai (kaibocai)
approved these changes
Mar 30, 2022
5 of 11 tasks
Chris Gillum (cgillum)
marked this pull request as ready for review
March 31, 2022 00:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a variety of changes, including:
I've also updated the version of the Durable Task sidecar (docker.io/cgillum/durabletask-sidecar:latest) which is compatible with these changes.
Things that still need to be done: