Report Durable Functions JavaScript SDK version in binding metadata - #369
Varshitha Bachu (bachuv) wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The metadata generation and propagation are consistent and appropriately tested.
Review effort: Balanced
Findings: None
What changed in this PR
Adds package identity metadata to Durable Functions bindings for extension telemetry and indexing.
Changes:
- Generates SDK name and version constants from
package.json. - Adds SDK identity to Durable gRPC metadata.
- Tests metadata values and binding immutability.
| File | Description |
|---|---|
packages/azure-functions-durable/test/unit/durable-grpc.spec.ts |
Verifies SDK metadata and immutability. |
packages/azure-functions-durable/src/durable-grpc.ts |
Adds SDK identity to binding metadata. |
packages/azure-functions-durable/package.json |
Generates version constants before builds and tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Non-blocking: assert SDK identity on the exported binding helpers In trigger.spec.ts, please extend the existing orchestration, activity, entity, and durable-client binding tests to assert |
Summary
What changed?
packages/azure-functions-durable/package.jsonbefore builds and tests.durableSdkNameanddurableSdkVersionto the metadata produced byaddDurableGrpcMetadata.durableRequiresGrpcon orchestration, activity, entity, and Durable Client bindings.Why is this change needed?
package.jsonso the reported identity remains synchronized with the published package.Issues / work items
Project checklist
CHANGELOG.mdAI-assisted code disclosure (required)
Was an AI tool used? (select one)
If AI was used:
AI verification (required if AI was used):
Notes for reviewers
src/version.tsis generated during the npmprebuild,pretest, andpretest:unitlifecycle steps and is not committed.package.jsonremains the source of truth for both the SDK package name and version.