Skip to content

Add ContainerStatistics proto messages for Stats shim query - #695

Closed
Justin (jterry75) wants to merge 1 commit into
microsoft:masterfrom
jterry75:container_stats
Closed

Add ContainerStatistics proto messages for Stats shim query#695
Justin (jterry75) wants to merge 1 commit into
microsoft:masterfrom
jterry75:container_stats

Conversation

@jterry75

@jterry75 Justin (jterry75) commented Sep 17, 2019

Copy link
Copy Markdown
Contributor

Implements WCOW/LCOW V2 container statistics queries on the shim stats calls.

Signed-off-by: Justin Terry (VM) juterry@microsoft.com

@jterry75

Copy link
Copy Markdown
Contributor Author

Kevin Parsons (@kevpar) - This is just the proto part but should unblock you

Comment thread vendor/github.com/containerd/cgroups/blkio.go Outdated
Comment thread cmd/containerd-shim-runhcs-v1/options/runhcs.proto Outdated
Comment thread cmd/containerd-shim-runhcs-v1/options/runhcs.proto Outdated
Comment thread cmd/containerd-shim-runhcs-v1/stats/stats.proto
@jterry75 Justin (jterry75) changed the title Add ContainerStatistics proto messages for Stats shim query [WIP] Add ContainerStatistics proto messages for Stats shim query Sep 18, 2019
@jterry75
Justin (jterry75) force-pushed the container_stats branch 2 times, most recently from 66e11a7 to edf78f8 Compare October 9, 2019 18:15
@jterry75 Justin (jterry75) changed the title [WIP] Add ContainerStatistics proto messages for Stats shim query Add ContainerStatistics proto messages for Stats shim query Oct 9, 2019
@jterry75

Copy link
Copy Markdown
Contributor Author

Kathryn Baldauf (@katiewasnothere), Kevin Parsons (@kevpar) - This is close. We need to implement the method in the OpenGCS for LCOW to match the host expectation in hcs_task.go but I believe this should be 90% there.

Kathryn Baldauf (@katiewasnothere) - Please take the commit test/improve and feel free to carry onto a new PR or push a new commit here if needed. Thanks

Implements WCOW/LCOW V2 container statistics queries on the shim stats calls.

Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
@jterry75

Copy link
Copy Markdown
Contributor Author

Kathryn Baldauf (@katiewasnothere) - Ok that should fix the build break in the test code.

@jterry75

Copy link
Copy Markdown
Contributor Author

Kathryn Baldauf (@katiewasnothere) - Do we want to take this PR and then you submit your changes or do we want to close it out?

@jterry75

Copy link
Copy Markdown
Contributor Author

Closing in favor of #719. Lantao Liu (@Random-Liu) - Should be good to revendor into upstream now.

@jterry75
Justin (jterry75) deleted the container_stats branch October 18, 2019 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants