Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Update for compiler changes in qsharp-compiler#643#328

Merged
rmshaffer merged 12 commits into
mainfrom
beheim/diagnostics
Oct 16, 2020
Merged

Update for compiler changes in qsharp-compiler#643#328
rmshaffer merged 12 commits into
mainfrom
beheim/diagnostics

Conversation

@rmshaffer

@rmshaffer rmshaffer commented Sep 24, 2020

Copy link
Copy Markdown
Contributor

Updates to account for changes in microsoft/qsharp-compiler#643. In particular, EntryPointInLibrary is becoming a warning rather than an error, so we need to update IQ# code and tests accordingly.

This will resolve #266 and in general will avoid differences in behavior depending on whether or not the Q# code being compiled contains an @EntryPoint().

To do before merging:

@rmshaffer rmshaffer changed the title Update for latest compiler changes Update for compiler changes in qsharp-compiler#643 Oct 8, 2020
@bettinaheim
bettinaheim marked this pull request as ready for review October 16, 2020 00:44
@bettinaheim bettinaheim self-assigned this Oct 16, 2020
bettinaheim
bettinaheim previously approved these changes Oct 16, 2020
@rmshaffer
rmshaffer requested a review from bettinaheim October 16, 2020 17:10
@rmshaffer
rmshaffer merged commit c8b54f7 into main Oct 16, 2020
@rmshaffer
rmshaffer deleted the beheim/diagnostics branch October 16, 2020 17:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect compilation of within/apply block when code contains @EntryPoint()

2 participants