Use default package location

[Raymond Zhao (rzhao271)]

In https://dev.azure.com/monacotools/Monaco/_build/results?buildId=229140&view=logs&j=9c6ceecd-5363-56f1-0e78-199c2ab175fa&t=dcca69f2-0e61-5643-f82d-945c312c3de6, we see the download task download the artifact to $(Build.SourcesDirectory) directly. It then tries to upload $(Build.SourcesDirectory)/packages/python/dist to ESRP later but can't find it. The default packageLocation value is $(Build.SourcesDirectory)/dist, which would have found the artifact.

A question I have is where does the download task come from? I don't see any download tasks defined under vscode-engineering/azure-pipelines/pypi-package, but I do see one defined under

lsprotocol/azure-pipelines/template/publish_pypi.yml

Line 14 in 790f259

- task: DownloadPipelineArtifact@2

. Is that template involved with the run, or is that just a coincidence?

CC Ladislau Szomoru (@lszomoru)

[Ladislau Szomoru (lszomoru)]

Raymond Zhao (@rzhao271), please bear with me 😁

The "Publish" stage of the pipeline templates (extension, npm package, pypi package) are using a deployment job. This is a special type of job, that is run against an "environment". We are using these as at the "environment" level we can set up various policies (ex: approval). One peculiarity of these deployment jobs is that they automatically get the download task injected so that all pipeline artefacts are automatically downloaded.

If you do not want to leverage the built-in functionality (maybe you do not want to download all artefacts) you can do the following: https://github.com/microsoft/vscode-engineering/blob/77d5746c62454a112d69aa41bf8c5953c421597d/azure-pipelines/npm-package/templates/jobs/publish.yml#L39-L40

Let me know if this helps. Also please feel free to ping me on Slack if you have any further questions or concerns. Thanks!

[Raymond Zhao (rzhao271)]

Thanks for the clarification, Lad!
This PR should be good to go, then.