[python] Make the method fields of requests, responses and notifications literals - #355
Merged
Karthik Nadig (karthiknadig) merged 1 commit intoJun 6, 2024
Conversation
…ons literals
This makes it possible for cattrs to build a disambiguation function
based on this unique field, which allows one to do things like:
```python
>>> from lsprotocol import types, converters
>>>
>>> converter = converters.get_converter()
>>> d = {"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"Server starting"}}
>>> converter.structure(d, types.NOTIFICATIONS | types.REQUESTS)
WindowLogMessageNotification(params=LogMessageParams(type=<MessageType.Info: 3>, message='Server starting'), method='window/logMessage', jsonrpc='2.0')
```
Contributor
Author
|
@microsoft-github-policy-service agree |
Karthik Nadig (karthiknadig)
requested review from
Eleanor Boyd (eleanorjboyd) and
Karthik Nadig (karthiknadig)
June 6, 2024 14:46
Karthik Nadig (karthiknadig)
approved these changes
Jun 6, 2024
Eleanor Boyd (eleanorjboyd)
approved these changes
Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible for cattrs to build a disambiguation function based on this unique field, which allows one to do things like: