[rust] Consider using url::Url for DocumentUri and URI types - #361
Merged
Merged
Conversation
Author
|
@microsoft-github-policy-service agree |
Author
|
Oh, I found some relevant discussions against So String may actually be good |
Member
|
Taya (@39555) Thanks for the suggestion and PR. |
Karthik Nadig (karthiknadig)
self-requested a review
June 24, 2024 16:01
Karthik Nadig (karthiknadig)
enabled auto-merge (squash)
June 24, 2024 16:03
Karthik Nadig (karthiknadig)
approved these changes
Jun 24, 2024
Martin Aeschlimann (aeschli)
approved these changes
Jun 24, 2024
Karthik Nadig (karthiknadig)
pushed a commit
to karthiknadig/lsprotocol
that referenced
this pull request
Aug 7, 2024
…icrosoft#361) Hi! Currently all URI types are represented as `String`, which is very uncomfortable to work with. This pr - adds the `serde` feature to `url` crate in Cargo.toml - adds `use url::Url;` - changes the rust generator to generate `Url` instead of `String` for `DocumentUri` and `URI` types This is similar to what [lsp-types](https://crates.io/crates/lsp-types) crate does. Are there any disadvantages to doing so?
Karthik Nadig (karthiknadig)
pushed a commit
that referenced
this pull request
Aug 12, 2024
) Hi! Currently all URI types are represented as `String`, which is very uncomfortable to work with. This pr - adds the `serde` feature to `url` crate in Cargo.toml - adds `use url::Url;` - changes the rust generator to generate `Url` instead of `String` for `DocumentUri` and `URI` types This is similar to what [lsp-types](https://crates.io/crates/lsp-types) crate does. Are there any disadvantages to doing so?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Currently all URI types are represented as
String, which is very uncomfortable to work with. This prserdefeature tourlcrate in Cargo.tomluse url::Url;Urlinstead ofStringforDocumentUriandURItypesThis is similar to what lsp-types crate does.
Are there any disadvantages to doing so?