Conversation
knangunu
requested review from
knangunu and
rahul577
and removed request for
rahul577
November 26, 2025 05:43
knangunu
approved these changes
Nov 26, 2025
Dave Smits (davesmits)
deleted the
feature/package-rollout-should-be-nullable
branch
November 26, 2025 12:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
made PackageRolloutPercentageOption nullable so that it's null when not provided instead of null.
other pieces of the code expect null to avoid setting the gradual rollout; but since it's read from the argument as float (instead of float?) it becomes 0 setting always gradual rollout.
fixes #110