Repository navigation
[WebNN] Rename roundingType to outputShapeRounding for pool2d ops - #28172
Merged
Guenther Schmuelling (guschmue) merged 2 commits intoApr 29, 2026
Merged
Conversation
Keep original roundingType name for a period of time to ensure backward compatibility. Spec change: webmachinelearning/webnn#770
Contributor
Author
|
Dwayne Robinson (@fdwr), Guenther Schmuelling (@guschmue), PTAL, thanks! |
Dwayne Robinson (fdwr)
previously approved these changes
Apr 23, 2026
Dwayne Robinson (fdwr)
left a comment
Contributor
There was a problem hiding this comment.
👍 Thanks Wanming.
Co-authored-by: Dwayne Robinson <fdwr@hotmail.com>
Wanming Lin (Honry)
dismissed
Dwayne Robinson (fdwr)’s stale review
via
April 23, 2026 02:23
fda131e
Guenther Schmuelling (guschmue)
approved these changes
Apr 29, 2026
Guenther Schmuelling (guschmue)
merged commit Apr 29, 2026
8a77597
into
microsoft:main
83 of 85 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep original roundingType name for a period of time to ensure backward compatibility.
Spec change: webmachinelearning/webnn#770