Repository navigation

feat: wait for active route handlers on page/context close - #28414

Merged

Yury Semikhatsky (yury-s) merged 2 commits into

microsoft:mainfrom

yury-s:route-auto-remove

Dec 5, 2023

Yury Semikhatsky (yury-s) commented Nov 30, 2023 •

edited

Loading

Member

Reference #23781

This comment has been minimized.

Sign in to view

Yury Semikhatsky (yury-s) force-pushed the route-auto-remove branch from 1933303 to b9ee467 Compare

November 30, 2023 02:22

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

Dmitry Gozman (dgozman) reviewed

View reviewed changes

packages/playwright-core/src/client/browserContext.ts Outdated

packages/playwright-core/src/client/browserContext.ts Outdated

Yury Semikhatsky (yury-s) force-pushed the route-auto-remove branch from b9ee467 to b479beb Compare

November 30, 2023 23:10

Dmitry Gozman (dgozman) reviewed

View reviewed changes

packages/playwright-core/src/client/browserContext.ts Outdated

packages/playwright-core/src/client/browserContext.ts Outdated

packages/playwright-core/src/client/network.ts Outdated

packages/playwright-core/src/client/network.ts Outdated

packages/playwright-core/src/client/network.ts Outdated

packages/playwright-core/src/client/page.ts Outdated

packages/playwright-core/src/client/page.ts Outdated

packages/playwright-core/src/client/page.ts Outdated

docs/src/api/class-browsercontext.md Outdated

tests/page/page-request-continue.spec.ts Outdated

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

Yury Semikhatsky (yury-s) force-pushed the route-auto-remove branch from 6f34c51 to d4da2d7 Compare

December 1, 2023 00:31

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

Yury Semikhatsky (yury-s) mentioned this pull request

fix: disable memory cache when intercepting in webkit #28458

Merged

Yury Semikhatsky (yury-s) force-pushed the route-auto-remove branch from d1e69d7 to fc88b92 Compare

December 1, 2023 22:58

This comment has been minimized.

Sign in to view

Yury Semikhatsky (yury-s) mentioned this pull request

fix(webkit): delay request event until requestIntercepted is received #28484

Merged

Yury Semikhatsky (yury-s) added a commit that referenced this pull request


          fix(webkit): delay request event until requestIntercepted is received (…

ab68d7b

…#28484)

Previously we were wrongly firing `route` event for the request which
are not in fact intercepted (e.g. requests from service worker).

Related #28414
Reference #23781

Yury Semikhatsky (yury-s) added 2 commits

December 4, 2023 13:04


          feat: wait for active route handlers on page/context close

16ad72f

Reference microsoft#23781


          Remove some nowaitfor

11f33b5

Yury Semikhatsky (yury-s) force-pushed the route-auto-remove branch from fc88b92 to 11f33b5 Compare

December 4, 2023 21:05

github-actions Bot commented Dec 4, 2023

Contributor

Test results for "tests 1"

6 flaky

⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [playwright-test] › ui-mode-test-ct.spec.ts:151:5 › should watch test
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks

26277 passed, 614 skipped
✔️✔️✔️

Merge workflow run.

Yury Semikhatsky (yury-s) merged commit 74e51d3 into microsoft:main

Yury Semikhatsky (yury-s) deleted the route-auto-remove branch

December 5, 2023 00:19

coderabbitai Bot mentioned this pull request

Added a React member detail screen behind a Labs flag TryGhost/Ghost#29345

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet