chore: remove unused eslint-disable directives - #35482
Merged
Yury Semikhatsky (yury-s) merged 2 commits intoApr 3, 2025
Merged
Conversation
Member
|
These are actually important, you should make sure they are checked. |
Yury Semikhatsky (yury-s)
requested review from
Dmitry Gozman (dgozman) and
Pavel Feldman (pavelfeldman)
and removed request for
Pavel Feldman (pavelfeldman)
April 3, 2025 21:56
Pavel Feldman (pavelfeldman)
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
packages/playwright-core/src/utils/. There must be one rule definition per path. Previously, there were multiple rule definitions for the same path (packages/playwright-core/src/utils/isomorphic/**/*.tsandpackages/playwright-core/src/utils/**/*.ts) and only one rule set worked, while we wanted to actually apply bothnoWebGlobalsRulesandnoNodeGlobalsRules.noWebGlobalsRulesis commented out for now until newly found violations inpackages/playwright-core/src/utils/are fixed or we chose a different way to address the builtins issue.