chore: do not escape css selectors for .css syntax - #36081
Merged
Pavel Feldman (pavelfeldman) merged 1 commit intoMay 26, 2025
Conversation
Pavel Feldman (pavelfeldman)
force-pushed
the
css_escape
branch
from
May 24, 2025 21:31
4f40e9d to
eaf7631
Compare
This comment has been minimized.
This comment has been minimized.
Dmitry Gozman (dgozman)
approved these changes
May 24, 2025
| return result; | ||
| export function cssEscape(selector: string): string { | ||
| // We are escaping it for document.querySelectorAll, not for usage in CSS file. | ||
| return selector.replace(/[:]/g, char => '\\' + char); |
Collaborator
There was a problem hiding this comment.
Will this work for bad .className, e.g. div.123? We use cssEscape for class names here.
This comment has been minimized.
This comment has been minimized.
Yury Semikhatsky (yury-s)
approved these changes
May 24, 2025
Pavel Feldman (pavelfeldman)
force-pushed
the
css_escape
branch
from
May 25, 2025 21:11
eaf7631 to
9593ed4
Compare
Contributor
Test results for "tests 1"7 flaky39230 passed, 804 skipped Merge workflow run. |
Dmitry Gozman (dgozman)
approved these changes
May 26, 2025
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.